[release/7.0] [mono][jit] Zero extend the return when we might be invoking llvm generated code #74991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
requested review from
vargaz,
lambdageek and
SamMonoRT
as code owners
|
cc @marek-safar - this needs your approval for backport to 7.0 -- this fixes #68914 and also blocking release issue #73304 |
SamMonoRT
approved these changes
Sep 2, 2022
|
The CI failure was:
Which has already been mitigated/fixed. I'll restart the failed CI legs so we can see the result logs. |
|
CI passed. |
marek-safar
approved these changes
Sep 6, 2022
vargaz
approved these changes
Sep 6, 2022
|
CI is green. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #74796 to release/7.0
/cc @SamMonoRT @BrzVlad
Customer Impact
Using of LLVM compilation engine on android can lead to crashes.
Testing
Tested the fix locally on an android test suite.
Risk
This change has low risk since it just adds a zero extend for the return of a call, having no other side effects.
IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.