[release/7.0] Fix argument validation in RuntimeType.InvokeMember #75006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
The rollout of `!!` erroneously moved an ArgumentNullException to be thrown earlier in the method, preventing a null name from being used (which is valid with BindingFlags.CreateInstance). (Separately, we should consider fixing the nullable reference type annotation on `string name`, since null is allowed in some circumstances.)
|
Tagging subscribers to this area: @dotnet/area-system-reflection Issue DetailsBackport of #74998 to release/7.0 /cc @stephentoub Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
carlossanlop
requested review from
buyaa-n,
AaronRobinsonMSFT and
steveharter
|
@buyaa-n / @steveharter / @AaronRobinsonMSFT need a code review sign off, please. |
jeffhandley
approved these changes
Sep 3, 2022
|
Approved for backport. Regression from previous release. |
buyaa-n
approved these changes
Sep 3, 2022
AaronRobinsonMSFT
approved these changes
Sep 3, 2022
|
Approved, signed off, CI green. Ready to merge. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #74998 to release/7.0
/cc @stephentoub
Customer Impact
Type.InvokeMember has historically allowed the member name argument to be null when specifying
BindingFlags.CreateInstance, since in that caseActivator.CreateInstanceis used and the member name is ignored. But the overhaul earlier in the release to use!!and then again to useArgumentNullException.ThrowIfNullerroneously resulting in the null check for non-CreateInstance cases being moved earlier in the method. The net result is passing a null name withBindingFlags.CreateInstancenow throws an ArgumentNullException rather than successfully instantiating the object. This fixes that to put the throw back where it should have been.Testing
New automated test, plus all CI testing plus local runs of the reflection tests.
Risk
Minimal