[release/7.0] Fix W^X flag for setting ITypeInfo
#75046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
jeffschwMSFT
approved these changes
Sep 3, 2022
jkotas
approved these changes
Sep 3, 2022
AaronRobinsonMSFT
added
the
NO-MERGE
|
The OP for the issue has reached out and is working on confirming this fixes their problem. From our perspective this should be the fix, but I'd like to make sure there aren't any other issues in this space prior to merging this in. /cc @ClearScriptLib |
AaronRobinsonMSFT
removed
the
NO-MERGE
|
Fix has been confirmed by @ClearScriptLib. This is ready for check-in. |
|
Approved, signed-off, CI green. Ready to merge. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #75045 to release/7.0
/cc @AaronRobinsonMSFT
Customer Impact
COM scenarios involving
IDispatchwhere aITypeInfoinstance is requested. This was reported by a user in #74977 (reply in thread).Testing
Confirmed fix by the finder of the issue described. No regressions confirmed by CI.
Risk
There is minimal risk here. This is a targeted fix that follows existing RW patterns for the
ComMethodTable.