-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/7.0] Update Roslyn compiler build #75156
Conversation
This PR is currently blocked on #75128. |
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsBackport of #75058 to release/7.0 /cc @cston Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
cc @danmoseley, this change is needed for 7.0 to move to the final SDK containing an updated compiler. |
@cston thanks for letting me know. Seems to me this falls under "infra necessary to ship" and thus automatically approved |
/azp run |
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
I see source generation build failures in all the Browser legs. I wonder if they are related to this change: Example of a job results: https://dev.azure.com/dnceng-public/public/_build/results?buildId=6110&view=logs&j=11c5c840-d20a-5536-428b-70d8cd9c6259&t=cdae1c92-5397-500e-687d-b0aafc3f5e3d&l=3169 Build failures:
|
@cston dotnet/runtime@ |
Other duplicate generator errors should be fixed by #75128 which was still in flight when this build started. |
so, this branch needs to merge upstream. |
Approved and signed off. |
Backport of #75058 to release/7.0
/cc @cston
Customer Impact
Testing
Risk
IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.