Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/7.0][wasm-mt] Fix pack/build issues in threaded builds #75171

Merged
merged 10 commits into from
Sep 8, 2022
Merged

[release/7.0][wasm-mt] Fix pack/build issues in threaded builds #75171

merged 10 commits into from
Sep 8, 2022

Commits on Sep 6, 2022

  1. [wasm-mt] Build the threaded CoreLib if MonoWasmBuildVariant is 'mult… 

    …ithread'

Also define the perf-tracing feature flag for the threaded and
perf-tracing build variants.
    @lambdageek
    lambdageek committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    7c7ecb8 View commit details
    Browse the repository at this point in the history

  2. Also fixup the BCL assemblies

    @lambdageek
    lambdageek committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    94c4e8b View commit details
    Browse the repository at this point in the history

  3. [wasm-mt] look for WasmEnableThreads in user projects 

    not WasmEnabelThreading.

Conversely, use `WasmEnablePerfTracing`, not `WasmEnablePerfTrace`.
    @lambdageek
    lambdageek committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    e5c2aae View commit details
    Browse the repository at this point in the history

  4. include dotnet.worker.js in runtime pack

    @lambdageek
    lambdageek committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    0fe387a View commit details
    Browse the repository at this point in the history

  5. use set "preferDirectoryName" to true in WASM templates

    @lambdageek
    lambdageek committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    364323d View commit details
    Browse the repository at this point in the history

  6. fix whitespace

    @lambdageek
    lambdageek committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    85789bd View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2022

  1. when updating RuntimePackNamePatterns don't include net7 component 

    The workload resolver already did its job by the time this property is
updated, so we need to use patterns that correspond to actual nupkg
names (unversioned), not runtime pack alias names from the
manifest (versioned with 'net7')
    @lambdageek
    lambdageek committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    76d0f01 View commit details
    Browse the repository at this point in the history

  2. WBT: unset MonoWasmBuildVariant for the non-threaded runtime 

    For local testing if the built runtime is a multithreaded one, make
and we need to make the normal variant nuget, unset
MonoWasmBuildVariant property
    @lambdageek
    lambdageek committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    a75226b View commit details
    Browse the repository at this point in the history

  3. [WorkloadBuildTasks] remove the workload manifest net6/net7 hack 

    Starting with 7.0.100-rc.2.22457.6 we already have the versioned
net6/net7 toolchains, so the hack isn't needed anymore (and in fact,
breaks workload installation during testing)
    @lambdageek
    lambdageek committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    a0ee879 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2022

  1. also build the JS interop library with threading if variant is used

    @lambdageek
    lambdageek committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    27370f0 View commit details
    Browse the repository at this point in the history