-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/7.0] Fix Exp10M1(TSelf)
and Round(TSelf, MidpointRounding)
#75284
Conversation
Tagging subscribers to this area: @dotnet/area-system-numerics Issue DetailsBackport of #75063 to release/7.0 Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
@tannergooding / @dakersnar need your code review sign off, please. |
@danmoseley This meets the bar as a "broken or significantly incomplete 7.0 scenario." |
Failing checks thus far are infrastructure issues.
|
Approved: perfect example of completing a new scenario based on customer feedback |
The llvmfullaot leg has been running for almost 4h. I wonder if it's stuck: https://dev.azure.com/dnceng-public/public/_build/results?buildId=8964&view=logs&j=d631b51d-8d68-5da3-5a13-95f6a763c7bb |
Ok, CI finished and is green. |
Backport of #75063 to release/7.0
/cc @tannergooding @Blokyk
Customer Impact
Users relying on the DIM (Default Interface Member) will end up with incorrect/unexpected behavior.
Testing
Additional tests covering the scenario were added.
Risk
Minimal, the impacted API surface is new for .NET 7 and so can only impact users who were taking an early dependency on the feature and who were relying on the DIM implementation.