-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set session ID when TLS resume is enabled #75435
Conversation
Tagging subscribers to this area: @dotnet/ncl, @vcsjones Issue Details
There are several references to it on Internet. https://www.openssl.org/docs/man1.1.1/man3/SSL_CTX_set_session_id_context.html mentioning that this error may happen with client certificates. This change will initialize ID to random bytes to prevent this error from happening. contributes to #75079
|
Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
/backport to release/7.0 |
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3042209571 |
There are several references to it on Internet. https://www.openssl.org/docs/man1.1.1/man3/SSL_CTX_set_session_id_context.html mentioning that this error may happen with client certificates.
This change will initialize ID to random bytes to prevent this error from happening.
So far I was unable to craft functional tests that could reproduce the issue. I have separate repro with Kestrel and Windows client as originally reported and this change fixes the observed failures.
contributes to #75079
I think e should take the fix for 7, leave it open for 8 to craft test that would reproduce the reported issue.