Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] [wasm][debugger] Fix evaluate expression on VS #75495

Merged
merged 2 commits into from
Sep 13, 2022

Conversation

github-actions[bot]
Copy link
Contributor

Backport of #75494 to release/7.0

/cc @lewing @thaystg

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Copy link
Member

@lewing lewing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just bundling assemblies in the task package no code change

@lewing
Copy link
Member

lewing commented Sep 13, 2022

[02:39:29] info: Discovered:  System.Runtime.Tests.dll (found 8915 of 9065 test cases)
[02:39:29] info: Using random seed for test cases: 1329103850
[02:39:29] info: Using random seed for collections: 1329103850
[02:39:29] info: Starting:    System.Runtime.Tests.dll

...
[EXECUTION TIMED OUT]
Exit Code:-3Executor timed out after 3600 seconds and was killed

['WasmTestOnBrowser-System.Runtime.Tests' END OF WORK ITEM LOG: Command timed out, and was killed]

@lewing
Copy link
Member

lewing commented Sep 13, 2022

https://dev.azure.com/dnceng-public/public/_build/results?buildId=14045&view=logs&j=ac444259-14dc-5e9e-4846-f4aabcc22cf0&t=3a9ab3ce-20e6-5db0-414f-a790b07334ea&l=38

    Determining projects to restore...
    All projects are up-to-date for restore.
    Determining projects to restore...
    All projects are up-to-date for restore.
/__w/1/s/src/tests/build.proj(437,5): error MSB3073: The command ""/__w/1/s/.dotnet/dotnet" restore -r linux-x64 Common/XUnitWrapperLibrary/XUnitWrapperLibrary.csproj  /p:SetTFMForRestore=true /p:TargetOS=Linux /p:TargetArchitecture=x64 /p:Configuration=Release /p:CrossBuild=" exited with code 1.

Build FAILED.

/__w/1/s/src/tests/build.proj(437,5): error MSB3073: The command ""/__w/1/s/.dotnet/dotnet" restore -r linux-x64 Common/XUnitWrapperLibrary/XUnitWrapperLibrary.csproj  /p:SetTFMForRestore=true /p:TargetOS=Linux /p:TargetArchitecture=x64 /p:Configuration=Release /p:CrossBuild=" exited with code 1.
    0 Warning(s)
    1 Error(s)

Time Elapsed 00:00:11.71
Build failed with exit code 1. Check errors above.
Failed to build tests. See the build logs:
    /__w/1/s/artifacts/log/Layout.Linux.x64.Release.log
    /__w/1/s/artifacts/log/Layout.Linux.x64.Release.wrn
    /__w/1/s/artifacts/log/Layout.Linux.x64.Release.err
    /__w/1/s/artifacts/log/Layout.Linux.x64.Release.binlog
##[error]Bash exited with code '1'.

@lewing
Copy link
Member

lewing commented Sep 13, 2022

Failures are not related to the change which just bundles assemblies with the task

@carlossanlop
Copy link
Member

carlossanlop commented Sep 13, 2022

Failures are not related to the change which just bundles assemblies with the task

Thanks for confirming, @lewing. Approved and signed off, so ready to merge. :shipit:

@carlossanlop carlossanlop merged commit b483931 into release/7.0 Sep 13, 2022
@carlossanlop carlossanlop deleted the backport/pr-75494-to-release/7.0 branch September 13, 2022 16:46
@ghost ghost locked as resolved and limited conversation to collaborators Oct 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants