[release/7.0] load quic early to prevent interaction with tests #75603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* load quic early to prevent interaction with tests * update Debian10 image for x64 * rever helix change * feedback from review * remove quic reference * Update src/libraries/System.Net.Security/tests/FunctionalTests/TestHelper.cs Co-authored-by: Jan Kotas <jkotas@microsoft.com>
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/ncl, @vcsjones Issue DetailsBackport of #75488 to release/7.0 /cc @wfurt @karelz @CarnaViire Customer ImpactTBA TestingCI RiskLow. Test-only change
|
karelz
approved these changes
Sep 14, 2022
|
CI failure is #75611 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #75488 to release/7.0
Fixes #75484
/cc @wfurt @karelz @CarnaViire
Customer Impact
Test only change to stabilize networking tests - avoid crashes on
arm64-Monodue to a bug inlttng(dependency ofMsQuic).Essentially the same as #75424 but for
System.Net.SecurityandSystem.Net.Mail-- details:When msquic is loaded it will also initialize
lttng. That callswaitand it can reap processes fromRemoteExecutorand that will cause Assert inProcesscode. (long story and evidence is in #74795)While the problem really lives in
lttngthere is no quick fix for that. To void the problem this change tries to loadMsQuicearly via static variable and that will initializelttngbefore any tests actually start.Testing
CI
Risk
Low. Test-only change