[release/7.0-rc2] [wasm] hide interop delegates from intellisense #75825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
requested review from
lewing and
pavelsavara
as code owners
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
gewarren
approved these changes
Sep 19, 2022
|
@lewing I suppose this change can be considered infra/tell-mode, correct? Also, test failure is unrelated (System.Net). |
radical
approved these changes
Sep 19, 2022
carlossanlop
approved these changes
Sep 19, 2022
There was a problem hiding this comment.
Signing off since this is a change that only affects documentation/intellisense.
CI failure is unrelated: #75611
Ready to merge. 
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #75800 to release/7.0-rc2
/cc @pavelsavara
Customer Impact
There are delegate types
ArgumentToManagedCallback<>andArgumentToJSCallback<>which are used by Roslyn code generator of the JavaScript interop.They are not intended to be used directly by the developer and we could hide them from intellisense.
Related discussion dotnet/dotnet-api-docs#8392 (comment)
Testing
Risk
IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.