[release/7.0-rc2] [wasm][debugger] Fix behavior of JMC #75833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
requested review from
thaystg and
radical
as code owners
|
Tagging subscribers to this area: @thaystg Issue DetailsBackport of #75783 to release/7.0-rc2 /cc @thaystg Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
|
@thaystg please fill out the template, add the |
carlossanlop
added
Servicing-approved
|
Approved via email by Tactics. |
radical
approved these changes
Sep 19, 2022
|
CI is green, approved and signed off. Ready to merge. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #75783 to release/7.0-rc2
/cc @thaystg
Customer Impact
It was not possible to view any member of types from non-user-code if JMC was enabled. And the expected behavior should be to hide only the private members.
Testing
Manual tested and unit test added
Risk
Low risk, only fixing the new behavior.
IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.