-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ActivatorUtilities not depending on ctor order for creating instances #75846
Merged
Commits on Oct 8, 2022
-
Fixes the bug with behaviour dependence on order of constructor defin…
…ition. Tries to find the longest constructor matching all parameters based on the behaviour of IServiceProviderIsService. - All the instance arguments passed in to CreateInstance were required before and should remain required after the breaking change. - Generally we do not want CreateInstance to be as strict as CreateFactory. - CreateInstance needs to account for the case where a container is potentially misconfigured. If for any reason IServiceProviderIsService ends returns false for a service which is actually registered, should still work today, but it is ok to give false negative. - If none are found, try to fallback to CreateFactory, more than one throw - if IServiceProviderIsService is not present fallback to CreateFactory. - If IServiceProviderIsService is configured wrong, or does not exist, it is OK for the API to function incorrectly or ambiguously.
Configuration menu - View commit details
-
Copy full SHA for 84d9662 - Browse repository at this point
Copy the full SHA 84d9662View commit details
Commits on Oct 11, 2022
-
Configuration menu - View commit details
-
Copy full SHA for a3de5c0 - Browse repository at this point
Copy the full SHA a3de5c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for fcd0f5b - Browse repository at this point
Copy the full SHA fcd0f5bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 42152c5 - Browse repository at this point
Copy the full SHA 42152c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for f8d5069 - Browse repository at this point
Copy the full SHA f8d5069View commit details -
Configuration menu - View commit details
-
Copy full SHA for cf36a7d - Browse repository at this point
Copy the full SHA cf36a7dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 54b1af1 - Browse repository at this point
Copy the full SHA 54b1af1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 54e17ae - Browse repository at this point
Copy the full SHA 54e17aeView commit details
Commits on Oct 13, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 5fa924c - Browse repository at this point
Copy the full SHA 5fa924cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.