[release/7.0] Fix public key token of Serialization.Schema contract assembly #75973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
The Microsoft public key token was only applied to the source assembly but not to the contract.
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsBackport of #75963 to release/7.0 /cc @ViktorHofer Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
eerhardt
approved these changes
Sep 21, 2022
|
I talked with @ericstj about this offline and we want to treat this as an infrastructure change as nothing is impacted yet but presumably a library in this repo could start referencing the Serialization.Schema library still before GA. |
|
Tell mode change, cc @ericstj @danmoseley |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #75963 to release/7.0
/cc @ViktorHofer
Customer Impact
Right now, this change doesn't correct any observable broken customer impact as no library in dotnet/runtime yet bind against Serialization.Schema. Still, I decided to create a backport as presumably a library in this repo could start referencing it and then backport such a change into release/7.0.
Testing
I verified that the produced contract and implementation assembly now contain the Microsoft strong name public key token. Automation to capture this as part of the build will be enabled in main as part of #73263.
Risk
Low. The public key token in the contract will be changed from Open to Microsoft. The package only supports modern .NET (net7.0), which means this isn't applicable to .NET Framework and the contract assembly doesn't even ship inside the package. This only affects libraries inside dotnet/runtiem that bind against the Serialization.Schema's contract assembly (via a ProjectReference).