Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] Update RateLimiting ref assembly #75978

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 21, 2022

Backport of #75976 to release/7.0

/cc @BrennanConroy

Customer Impact

Customers will see that some properties are settable on a type when they shouldn't be. This doesn't cause issues in our code because we give the object to the customer for their own consumption and don't use it after. But it isn't great that we expose the properties for users to set when they aren't meant to be.

Testing

Manually verified the ref assembly has the updated information via ILSpy.

Risk

Low, no code changes, just an updated attribute on properties in the ref assembly.

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Sep 21, 2022

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #75976 to release/7.0

/cc @BrennanConroy

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-Infrastructure-libraries, new-api-needs-documentation

Milestone: -

@BrennanConroy BrennanConroy added the Servicing-consider Issue for next servicing release review label Sep 21, 2022
@BrennanConroy BrennanConroy added this to the 7.0.0 milestone Sep 21, 2022
@ViktorHofer ViktorHofer removed Servicing-consider Issue for next servicing release review new-api-needs-documentation labels Sep 21, 2022
@ViktorHofer ViktorHofer merged commit a5e1fd5 into release/7.0 Sep 22, 2022
@ViktorHofer ViktorHofer deleted the backport/pr-75976-to-release/7.0 branch September 22, 2022 07:25
@ghost ghost locked as resolved and limited conversation to collaborators Oct 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants