Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable doc generation for source-build #75981

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

carlossanlop
Copy link
Member

Fixes dotnet/source-build#2877

This is a forward port of this 6.0 change: #59937

Will backport to 7.0.

Kudos to @MichaelSimons for helping me find the missing change.

@ghost
Copy link

ghost commented Sep 21, 2022

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes dotnet/source-build#2877

This is a forward port of this 6.0 change: #59937

Will backport to 7.0.

Kudos to @MichaelSimons for helping me find the missing change.

Author: carlossanlop
Assignees: carlossanlop
Labels:

area-Infrastructure-libraries

Milestone: -

@carlossanlop
Copy link
Member Author

/backport to release/7.0-rc2

@github-actions
Copy link
Contributor

Started backporting to release/7.0-rc2: https://github.com/dotnet/runtime/actions/runs/3100059329

@carlossanlop
Copy link
Member Author

I asked, and it is not needed for RC2, so I'll backport it to GA directly.

@carlossanlop
Copy link
Member Author

/backport to release/7.0

@github-actions
Copy link
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3100139684

@carlossanlop
Copy link
Member Author

CI is all green. The llvmfullaot leg shouldn't be testing anything from this change.

@carlossanlop carlossanlop merged commit 46a93d9 into dotnet:main Sep 21, 2022
@carlossanlop carlossanlop deleted the DocsSourceBuildFix branch September 21, 2022 22:19
@ghost ghost locked as resolved and limited conversation to collaborators Oct 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7.0 source-built SDK packs are missing missing xml doc
4 participants