Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0][wasm] Update templates to add framework argument #76123

Merged
merged 2 commits into from
Sep 26, 2022

Conversation

radical
Copy link
Member

@radical radical commented Sep 24, 2022

For supporting templates installed from two different wasm workloads, like wasm-experimental, and wasm-experimental-7, they need to be differentiated.

  • Update identity to be unique with .7.0 suffix
  • Add a framework parameter with default value of net7.0
$ dotnet new wasmbrowser -h
Template options:
Template options:
  -F, --Framework <net7.0>  The target framework for the project.
                            Type: choice
                              net7.0  Target net7.0
                            Default: net7.0

@radical radical added arch-wasm WebAssembly architecture area-Build-mono labels Sep 24, 2022
@radical radical added this to the 7.0.0 milestone Sep 24, 2022
@ghost ghost assigned radical Sep 24, 2022
@ghost
Copy link

ghost commented Sep 24, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

For supporting templates installed from two different wasm workloads, like wasm-experimental, and wasm-experimental-7, they need to be differentiated.

  • Update identity to be unique with .7.0 suffix
  • Add a framework parameter with default value of net7.0
    • this will be added for net8 templates also, and dotnet new will show both as options.
$ dotnet new wasmconsole -h
WebAssembly Browser App (C#)
Author: Microsoft
Description: WebAssembly Browser App

Usage:
  dotnet new wasmbrowser [options] [template options]

Options:
....

Template options:
  -f, --framework <net7.0|net8.0>  The target framework for the project.
                                   Type: choice
                                     net8.0  Target net8.0
                                     net7.0  Target net7.0
                                   Default: net8.0
Author: radical
Assignees: -
Labels:

arch-wasm, area-Build-mono

Milestone: 7.0.0

@carlossanlop
Copy link
Member

Assuming this is infra/test only, so no Tactics approval request needed.
@lewing / @pavelsavara / @radekdoulik can you please give a code review sign off?

@carlossanlop
Copy link
Member

Let's do this! 💪🏼 :shipit:

@carlossanlop carlossanlop merged commit e707f98 into dotnet:release/7.0 Sep 26, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Oct 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Build-mono
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants