Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] Replace GetFile() with GetPEAssembly() call in gdb #76321

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 28, 2022

Backport of #76293 to release/7.0

/cc @jkotas @tonybaloney

Customer Impact

Build break in source build configuration used by Tizen.

Testing

N/A. The affected code is not compiled into the official .NET distro.

Risk

Low

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

@jkotas jkotas added the Servicing-consider Issue for next servicing release review label Sep 28, 2022
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. we can merge when ready

@carlossanlop
Copy link
Member

approved. we can merge when ready

@jeffschwMSFT I can't find the Tactics approval email. Or was it approved in the meeting?

@jeffschwMSFT
Copy link
Member

we are treating this as 'tell mode' as it is not production code

@carlossanlop
Copy link
Member

we are treating this as 'tell mode' as it is not production code

Got it. Thanks. :shipit:

@carlossanlop carlossanlop added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Sep 28, 2022
@carlossanlop carlossanlop merged commit 10f8e71 into release/7.0 Sep 28, 2022
@carlossanlop carlossanlop deleted the backport/pr-76293-to-release/7.0 branch September 28, 2022 22:50
@ghost ghost locked as resolved and limited conversation to collaborators Oct 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-VM-coreclr Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants