Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate strict prototypes warning #76463

Merged
merged 14 commits into from
Oct 1, 2022
Merged

Conversation

yowl
Copy link
Contributor

@yowl yowl commented Sep 30, 2022

This PR reinstates the strict-prototype warning in most places. I wasn't able to do the one in System.IO.Compression

add_compile_options(-Wno-strict-prototypes)

because of these

/home/scott/github/runtime/src/native/external/zlib/adler32.c(63,15): error G7801012A: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Werror,-Wdeprecated-non-prototype] [/home/scott/github/runtime/src/native/libs/build-native.proj]
/home/scott/github/runtime/src/native/external/zlib/adler32.c(134,15): error G7801012A: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Werror,-Wdeprecated-non-prototype] [/home/scott/github/runtime/src/native/libs/build-native.proj]
/home/scott/github/runtime/src/native/external/zlib/adler32.c(143,13): error G7801012A: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Werror,-Wdeprecated-non-prototype] [/home/scott/github/runtime/src/native/libs/build-native.proj]
/home/scott/github/runtime/src/native/external/zlib/adler32.c(143,13): error G7801012A: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Werror,-Wdeprecated-non-prototype] [/home/scott/github/runtime/src/native/libs/build-native.proj]
/home/scott/github/runtime/src/native/external/zlib/adler32.c(172,15): error G7801012A: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Werror,-Wdeprecated-non-prototype] [/home/scott/github/runtime/src/native/libs/build-native.proj]
/home/scott/github/runtime/src/native/external/zlib/adler32.c(180,15): error G7801012A: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Werror,-Wdeprecated-non-prototype] [/home/scott/github/runtime/src/native/libs/build-native.proj]

Which look like a slightly different problem to the one of a missing void in the .c. function signature. Do you want me to investigate the adler32.c ones more?

This originates from the PR over at dotnet/runtimelab#2004 (comment)

Tested by running

./build.sh -os Browser -configuration Debug

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Sep 30, 2022
@yowl
Copy link
Contributor Author

yowl commented Oct 1, 2022

Thanks @jkotas . Are you expecting it to go through, or do you want me to pick up more of the voids today?

@jkotas
Copy link
Member

jkotas commented Oct 1, 2022

I can take care of it. I hope that the current CI run will be green.

There is a ton of these warnings in zlib that we want to wait for being fixed in the upstream zlib sources first. So I had to add some of the warning disable command line options back.

@jkotas jkotas merged commit d320fd9 into dotnet:main Oct 1, 2022
@yowl yowl deleted the strict-prototypes branch October 1, 2022 19:20
@ghost ghost locked as resolved and limited conversation to collaborators Nov 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants