-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reinstate strict prototypes warning #76463
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
5879c4a
to
ddf7b91
Compare
ddf7b91
to
5c1a7f7
Compare
Thanks @jkotas . Are you expecting it to go through, or do you want me to pick up more of the voids today? |
I can take care of it. I hope that the current CI run will be green. There is a ton of these warnings in zlib that we want to wait for being fixed in the upstream zlib sources first. So I had to add some of the warning disable command line options back. |
This PR reinstates the
strict-prototype
warning in most places. I wasn't able to do the one inSystem.IO.Compression
runtime/src/native/libs/System.IO.Compression.Native/CMakeLists.txt
Line 42 in 5481c4b
because of these
Which look like a slightly different problem to the one of a missing
void
in the.c.
function signature. Do you want me to investigate theadler32.c
ones more?This originates from the PR over at dotnet/runtimelab#2004 (comment)
Tested by running