Remove .dll from Interop.Libraries.HostPolicy for consistency with other runtime libraries #76466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov Issue Details
Resolves #60080
|
jkotas
reviewed
Sep 30, 2022
|
Opened #76494 on the Libraries Test Run checked coreclr windows x86 Debug crash |
jkotas
reviewed
Oct 4, 2022
jkotas
reviewed
Oct 4, 2022
| @@ -72,7 +72,7 @@ int main(const int argc, const pal::char_t *argv[]) | |||
| } | |||
|
|
|||
| nethost_path = get_directory(nethost_path); | |||
| nethost_path.append(MAKE_LIBNAME("nethost")); | |||
| nethost_path.append(LIB_FILE_NAME_X("nethost")); | |||
There was a problem hiding this comment.
Suggested change
| nethost_path.append(LIB_FILE_NAME_X("nethost")); | |
| nethost_path.append(LIB_FILE_NAME_X("nethost")); |
For my education - why is LIB_FILE_NAME not sufficient here?
There was a problem hiding this comment.
All the host components have strings (pal::char_t/pal::string_t) as wchar_t/std::wstring for Windows and char/std::string for non-Windows internally and for exported APIs, so this uses LIB_FILE_NAME_X to define it according to the platform.
jkotas
approved these changes
Oct 4, 2022
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
|
Failure is #76280. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interop.Libraries.HostPolicyis only used for the library name in p/invokes.Resolves #60080