[release/7.0] [mono][sgen] Update memory load information after world is resumed #76534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Following recent cgroup support, mono_determine_physical_ram_size is no longer safe to call during GC.
github-actions
bot
requested review from
BrzVlad,
lambdageek and
naricc
as code owners
|
Tagging subscribers to this area: @BrzVlad Issue DetailsBackport of #76400 to release/7.0 /cc @akoeplinger @BrzVlad Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
|
@steveisok @marek-safar please approve |
|
it needs to go via tactics approval |
lambdageek
approved these changes
Oct 3, 2022
|
@BrzVlad or @akoeplinger: please send an email to Tactics requesting approval. |
rbhanda
added
Servicing-approved
|
@carlossanlop this was approved by tactics, please merge :) |
|
CI green, signed off, approved. Ready! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #76400 to release/7.0
/cc @akoeplinger @BrzVlad
Customer Impact
Following recent cgroup support (#74237), mono_determine_physical_ram_size is no longer safe to call during GC. This can lead to random hangs during GC when running on linux desktop platforms.
Testing
CI and local testing
Risk
Low. Small change to when memory threshold stat is being updated.