Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JsonEncodedText.Value #76545

Merged
merged 2 commits into from
Oct 5, 2022
Merged

Conversation

schoder-moreno
Copy link
Contributor

@schoder-moreno schoder-moreno commented Oct 3, 2022

Fixes #69716

Added a few asserts to highlight that two JsonEncodedText instances A and B, when one of them is default, display the following behavior: A.Value == B.Value //true while A.Equals(B) //false.

Also updated usage (ToString() -> Value) in tests.

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Oct 3, 2022
@dnfadmin
Copy link

dnfadmin commented Oct 3, 2022

CLA assistant check
All CLA requirements met.

@ghost
Copy link

ghost commented Oct 3, 2022

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

#69716

Also updated usage (ToString() -> Value) in tests.

Author: schoder-moreno
Assignees: -
Labels:

area-System.Text.Json, new-api-needs-documentation

Milestone: -

@eiriktsarpalis eiriktsarpalis added this to the 8.0.0 milestone Oct 4, 2022
@eiriktsarpalis eiriktsarpalis marked this pull request as ready for review October 5, 2022 12:21
Copy link
Member

@eiriktsarpalis eiriktsarpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@eiriktsarpalis eiriktsarpalis self-assigned this Oct 5, 2022
@eiriktsarpalis eiriktsarpalis merged commit c27f486 into dotnet:main Oct 5, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Text.Json community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[API Proposal]: Add a JsonEncodedText.Value property
3 participants