[release/7.0] Ensure NI_Vector128_AsVector128 (aka Vector128<T> AsVector128(this Vector<T> value)) doesn't have a side-effect in its assert
#76547
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…ector<T> value)`) doesn't have a side-effect in its assert
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsBackport of #76460 to release/7.0 /cc @tannergooding Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
tannergooding
added
the
Servicing-consider
|
@tannergooding please send an email to Tactics requesting approval. |
|
@tannergooding, please check the test failures. |
|
Does this PR fix Arm64 failures that @BruceForstall mentioned in #76347? Or do we need to look into those further in addition to this fix? |
It fixes some of the failures, but not all of them. |
rbhanda
added
Servicing-approved
|
Approved, signed off, CI green. Ready |
ghost
locked as resolved and limited conversation to collaborators
Backport of #76460 to release/7.0
/cc @tannergooding
Customer Impact
Users get silent "bad" codegen and incorrect disassembly displayed in the new
DOTNET_JitDisasm=...feature.The impact of this silent bad codegen is believed to be minimal as while technically incorrect, the way a user consumes such values should normally not cause issue since they are only consuming the lower 16-bits. However, there may be unseen/unknown issues related to CSE or VN where this does lead to real failures but with no known repro at this time.
Testing
Additional testing validating the codegen were added.
Risk
Low. This path is already well tested from Debug/Checked builds and was the existing behavior in .NET 5 and prior. The relevant code was accidentally merged into an assert resulting in it being "gone" in Release builds sometime before .NET 6.