Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] [mono] Fix incorrect version comparison in loader #76698

Merged
merged 1 commit into from
Oct 7, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 6, 2022

Backport of #76665 to release/7.0

/cc @lambdageek @uweigand

Customer Impact

When customer code is compiled against older assemblies, but newer versions are available at runtime, certain combinations of old vs new versions wlll be compared incorrectly and the runtime will refuse to load the newer assembly believing it to be older than the older assembly.

This affects all platforms that use Mono as the execution engine (iOS, Android, WebAssembly, s390x Linux).

Testing

Manual testing

Risk

Low. The underlying issue is an incorrect order of comparison of the 3rd and 4th component of an assembly version. In many cases the 4th component is 0, so it doesn't matter if it's compared before or after the 3rd component since it doesn't affect the final result.

* Compare version components in the correct order in
  assembly_names_compare_versions

* Fixes #76664
@lambdageek lambdageek added the Servicing-consider Issue for next servicing release review label Oct 6, 2022
@lambdageek lambdageek added this to the 7.0.0 milestone Oct 6, 2022
@lambdageek lambdageek self-assigned this Oct 6, 2022
@rbhanda rbhanda added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Oct 6, 2022
@carlossanlop
Copy link
Member

carlossanlop commented Oct 7, 2022

CI failures are:

Aside from that, it has been approved and signed off. Ready to merge. :shipit:

@carlossanlop carlossanlop merged commit 236f3a7 into release/7.0 Oct 7, 2022
@carlossanlop carlossanlop deleted the backport/pr-76665-to-release/7.0 branch October 7, 2022 00:43
@ghost ghost locked as resolved and limited conversation to collaborators Nov 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-VM-meta-mono Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants