-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test][tvos] Disable InvalidIVSizes overflow case for tvos #76725
[test][tvos] Disable InvalidIVSizes overflow case for tvos #76725
Conversation
Tagging subscribers to 'os-tvos': @steveisok, @akoeplinger Issue DetailsThis test has flakily caused app crashes on tvOS arm64 lanes. dotnet/arcade#11167 Whereas on a successful test suite run, there are 3. Its suspected that the last test case is problematic, so disabling to make CI cleaner
|
Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones Issue DetailsThis test has flakily caused app crashes on tvOS arm64 lanes. dotnet/arcade#11167 Whereas on a successful test suite run, there are 3. Its suspected that the last test case is problematic, so disabling to make CI cleaner
|
/azp run runtime-ioslike |
Azure Pipelines successfully started running 1 pipeline(s). |
I'm planning to rerun the tvOS arm64 lane multiple times to see whether or not the System.Security.Cryptograph.Tests suite crashes |
@bartonjs this seems to happen somewhat randomly. The logs aren't capturing the crash with any detail. Can you speculate as to what might be happening? |
If this is indeed the culprit and we need to unblock CI here can we use an ActiveIssue and open an issue instead of a conditional to figure out why it's failing? I can look at this later. EDIT: oh it's a theory. I guess you can't put an ActiveIssue on just one case. I still think we should open a tracking issue and put that link in the skip exception. |
@vcsjones I'm not certain which test is the actual one causing the crash so I'll create an issue and add it after running it a few times to ensure that its no longer crashing if that test case is skipped Edit: Actually, I'll add the issue and link it in because I forgot to include the XUnitExtensions import anyways. |
/azp run runtime-ioslike |
Azure Pipelines successfully started running 1 pipeline(s). |
I don't think there's anything wrong with the crypto code, but rather the runtime or the test harness/runner. All the test does is:
So it seems likely that something during the execution of this test is falling over due to a low memory condition. Yeah, we could change the product code to notice that the array is the wrong size before cloning it, but that doesn't seem to address that we have either a CLR problem where the system doesn't tolerate low memory properly or a test harness problem where we're not capable of capturing this condition/state. |
/azp run runtime-ioslike |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-ioslike |
Azure Pipelines successfully started running 1 pipeline(s). |
Of the 3 runs of runtime-ioslike which runs tvOS arm64's System.Security.Cryptography.Tests suite, all have not crashed and the test is successfully ignored. |
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
I think we've seen similar issues in other test cases where gigantic arrays / OOM are involved, it looks like a more general Mono issue on low-memory devices. I'm fine with this as a quick fix but we should probably investigate more about the root cause. |
The remaining failures on runtime-extra-platforms are |
This test has flakily caused app crashes on tvOS arm64 lanes. dotnet/arcade#11167
When the app crashes, it was observed that of the last tests ran, there commonly was only 2
InvalidIVSizes
seehttps://gist.github.com/mdh1418/563ce4066e16dfee055e0903e2c70a1e
https://gist.github.com/mdh1418/ed11c7ba361c3fdb8906e57034c58f90
https://gist.github.com/mdh1418/c831b807dc0d949bc01cdeee61a1d795
Whereas on a successful test suite run, there are 3.
https://gist.github.com/mdh1418/912914871d580475751d460719624224
Its suspected that the last test case is problematic, so disabling to make CI cleaner