Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] Correct error messages for CoreCLR Win32 PAL uses in CoreLib #76813

Merged
merged 1 commit into from
Oct 10, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 10, 2022

Backport of #76768 to release/7.0

/cc @jkotas

Customer Impact

Exception thrown by synchronization classes on Unix have incorrect error messages. This makes diagnosing problems close to impossible.

Contributes to #76736

Testing

Verified that the correct message is produce by simulated error condition

Risk

Low

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. please get a code review and we can take for consideration in 7 ga.

@jeffschwMSFT jeffschwMSFT added area-ExceptionHandling-coreclr Servicing-consider Issue for next servicing release review labels Oct 10, 2022
@jeffschwMSFT jeffschwMSFT added this to the 7.0.0 milestone Oct 10, 2022
@carlossanlop carlossanlop added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Oct 10, 2022
@carlossanlop
Copy link
Member

Approved by Tactics via email.

@carlossanlop
Copy link
Member

CI failure is a timeout cancellation during test execution of Libraries Test Run release mono Linux arm64 Debug. Otherwise, it's green.
Approved and signed-off. Ready to merge. :shipit:

@carlossanlop carlossanlop merged commit 9c14efc into release/7.0 Oct 10, 2022
@carlossanlop carlossanlop deleted the backport/pr-76768-to-release/7.0 branch October 10, 2022 18:38
@ghost ghost locked as resolved and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants