-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Target only net7.0 during source-build - Port of #75168 to main #77052
Conversation
Port of dotnet#75168 to main. * Target net7.0 in additional projects * Update compatibility suppressions * Only target net7.0 for source-build * Disable package validation for source-build * Revert compatibility suppression changes * Use NetCoreAppCurrent instead of hardcoding net7.0 * Revert mono Apple TFM change * Remove unnecessary LangVersion
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsPort of #75168 to main. These changes are also needed to support building main in source build.
|
Unlike the release/7.0 change, this commit isn't here:
Does that line not exist in main? |
Correct, looks like it is already removed: https://github.com/dotnet/runtime/blob/main/src/libraries/System.Diagnostics.DiagnosticSource/src/System.Diagnostics.DiagnosticSource.csproj#L8 |
src/libraries/System.Text.RegularExpressions/tools/GenerateRegexCasingTable.csproj
Outdated
Show resolved
Hide resolved
src/libraries/System.Text.RegularExpressions/tools/GenerateRegexCasingTable.csproj
Outdated
Show resolved
Hide resolved
src/libraries/System.Text.RegularExpressions/tools/GenerateRegexCasingTable.csproj
Outdated
Show resolved
Hide resolved
@ViktorHofer anything else that needs to happen before this is merged? Thanks! |
Port of #75168 to main. These changes are also needed to support building main in source build.
Target net7.0 in additional projects
Update compatibility suppressions
Only target net7.0 for source-build
Disable package validation for source-build
Revert compatibility suppression changes
Use NetCoreAppCurrent instead of hardcoding net7.0
Revert mono Apple TFM change
Remove unnecessary LangVersion