[release/7.0] [mono][interp] Fix an issue with deopt and interpreter tiering. #77059
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
If a method is tiered while being run from interp_run_clause_with_il_state (), the clause_args argument to interp_exec_method () still contains the old IL offsets confusing the EH code, i.e. this line: ``` if (clause_args && frame == clause_args->exec_frame && context->handler_ip >= clause_args->end_at_ip) ``` Clear out clause_args at the beginning to avoid this. Hopefully fixes #76134 #74302
The IL offsets in the clause_args argument become out-of-date after tiering up.
|
Tagging subscribers to this area: @BrzVlad Issue DetailsBackport of #76743 to release/7.0 Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
|
We should not merge till we have clarity on this comment from @BrzVlad - #76743 (comment) [SamP] - This issue has been addressed and we can proceed with this backport |
There was a problem hiding this comment.
I have some ideas for improving clarity around the use of clause_args, but I can work on them later, for .net 8.
[SamP] -The current changes for 7.0 are fine and cause no other regressions but fix the issue. Vlad has a possible better implementation idea for .NET 8
|
Any updates on this? It has not gone through Tactics approval yet. |
carlossanlop
added
the
NO-MERGE
lewing
added
Servicing-consider
rbhanda
added
Servicing-approved
|
CI is green. Tactics approved it. Signed off by area owners. No OOB package authoring changes needed (native code). Ready to merge. |
ghost
locked as resolved and limited conversation to collaborators
Backport of #76743 to release/7.0
/cc @lewing @vargaz
Customer Impact
Can cause random failures on WebAssembly in AOT mode.
Testing
This is low frequency timing related issue that is difficult to reproduce outside of CI but CI has been passing in main after the fix
Risk
Low, only affects WebAssembly in AOT mode.
IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.