Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ILLink running in incremental builds #77110

Merged
merged 1 commit into from
Oct 17, 2022
Merged

Conversation

ViktorHofer
Copy link
Member

Now that the new APICompat runs after all the compilation targets, this depends on in illink.targets isn't necessary anymore and fixes the incremental build issue.

Regressed with 960e4d7 as the new APICompat doesn't run as post compiler target anymore but instead, as part of the PrepareForRun target. That caused the ILLink dependent target to always run, even if the compiler didn't run and the inputs/outputs didn't change.

cc @smasher164

Now that the new APICompat runs after all the compilation targets, this depends on in illink.targets isn't necessary anymore and fixes the incremental build issue.

Regressed with 960e4d7 as the new APICompat doesn't run as post compiler target anymore but instead, as part of the `PrepareForRun` target. That caused the ILLink dependent target to always run, even if the compiler didn't run and the inputs/outputs didn't change.
@ViktorHofer ViktorHofer self-assigned this Oct 17, 2022
@ghost ghost added the linkable-framework Issues associated with delivering a linker friendly framework label Oct 17, 2022
@ghost
Copy link

ghost commented Oct 17, 2022

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Now that the new APICompat runs after all the compilation targets, this depends on in illink.targets isn't necessary anymore and fixes the incremental build issue.

Regressed with 960e4d7 as the new APICompat doesn't run as post compiler target anymore but instead, as part of the PrepareForRun target. That caused the ILLink dependent target to always run, even if the compiler didn't run and the inputs/outputs didn't change.

cc @smasher164

Author: ViktorHofer
Assignees: ViktorHofer
Labels:

area-Infrastructure

Milestone: -

@ghost
Copy link

ghost commented Oct 17, 2022

Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr
See info in area-owners.md if you want to be subscribed.

Issue Details

Now that the new APICompat runs after all the compilation targets, this depends on in illink.targets isn't necessary anymore and fixes the incremental build issue.

Regressed with 960e4d7 as the new APICompat doesn't run as post compiler target anymore but instead, as part of the PrepareForRun target. That caused the ILLink dependent target to always run, even if the compiler didn't run and the inputs/outputs didn't change.

cc @smasher164

Author: ViktorHofer
Assignees: ViktorHofer
Labels:

area-Infrastructure, linkable-framework

Milestone: -

@ViktorHofer ViktorHofer merged commit 3e8a5b1 into main Oct 17, 2022
@ViktorHofer ViktorHofer deleted the ViktorHofer-patch-1 branch October 17, 2022 13:50
@ghost ghost locked as resolved and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure linkable-framework Issues associated with delivering a linker friendly framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants