Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Use latest stable version of chrome for testing #77133

Merged
merged 4 commits into from
Oct 25, 2022
Merged

[wasm] Use latest stable version of chrome for testing #77133

merged 4 commits into from
Oct 25, 2022

Conversation

radical
Copy link
Member

@radical radical commented Oct 17, 2022 •
edited
Loading

  • Use the latest stable chrome version by default
  • Install these by default on codespaces

Details

  • Added a new task GetChromeVersions to get the latest version
  • This is applicable to library tests, debugger tests, and Wasm.Build.Tests
  • The channel used for getting the "latest" version is $(ChromeChannel)=stable
  • And they are installed in artifacts/bin/chrome, and artifacts/bin/chromedriver
  • A newer version is fetched only $(ChromeVersionCheckThresholdDays)=3 days after the last version check
  • This is enabled by default on containers
  • And the behavior can be disabled with $(InstallChromeForTests)=false.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost assigned radical Oct 17, 2022
@radical radical added arch-wasm WebAssembly architecture area-Infrastructure-mono labels Oct 17, 2022
@radical radical added this to the 8.0.0 milestone Oct 17, 2022
@ghost
Copy link

ghost commented Oct 17, 2022

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details
  • This is applicable to library tests, debugger tests, and Wasm.Build.Tests
  • The channel to used for getting the "latest" version is $(ChromeChannel)=stable
  • And they are installed in artifacts/bin/chrome, and artifacts/bin/chromedriver
  • A newer version is fetched only $(ChromeVersionCheckThresholdDays)=3 days after the last version check
  • This is enabled by default on containers
  • And the behavior can be disabled with $(InstallChromeForTests)=false.
Author: radical
Assignees: radical
Labels:

arch-wasm, area-Infrastructure-mono
Milestone: -

@halter73 halter73 removed the arch-wasm WebAssembly architecture label Oct 17, 2022
@radical
Copy link
Member Author

radical commented Oct 17, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical radical added the arch-wasm WebAssembly architecture label Oct 17, 2022
@ghost
Copy link

ghost commented Oct 17, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Use the latest stable chrome version by default
  • Install these by default on codespaces

Details

  • This is applicable to library tests, debugger tests, and Wasm.Build.Tests
  • The channel to used for getting the "latest" version is $(ChromeChannel)=stable
  • And they are installed in artifacts/bin/chrome, and artifacts/bin/chromedriver
  • A newer version is fetched only $(ChromeVersionCheckThresholdDays)=3 days after the last version check
  • This is enabled by default on containers
  • And the behavior can be disabled with $(InstallChromeForTests)=false.
Author: radical
Assignees: radical
Labels:

arch-wasm, area-Infrastructure-mono
Milestone: 8.0.0

@radical
Copy link
Member Author

radical commented Oct 17, 2022

@halter73 Why was the arch-wasm label removed on this PR?

@radical radical requested review from lewing and kg October 17, 2022 23:49
@radical radical changed the title [wasm] Use latest version of stable chrome for testing [wasm] Use latest stable version of chrome for testing Oct 17, 2022
@radical radical added the NO-REVIEW Experimental/testing PR, do NOT review it label Oct 18, 2022
@radical radical removed the NO-REVIEW Experimental/testing PR, do NOT review it label Oct 22, 2022
@radical radical force-pushed the chrome-provisioning branch 2 times, most recently from ba8f94c to 1667f4f Compare October 22, 2022 21:44
@radical
[wasm] Add InstallChrome task
1836218
@radical
[wasm] Download latest stable version of chrome for testing
b6b3bfa 
- Rename provisioning.targets to wasm-provisioning.targets
- Use the new task to install chrome, and chromedriver
@radical
[wasm] Use the provisioned chrome
d7d0e52
@build-analysis build-analysis bot mentioned this pull request Oct 23, 2022
Closed
@radical radical marked this pull request as ready for review October 23, 2022 08:23
@radical radical requested a review from thaystg as a code owner October 23, 2022 08:23
@build-analysis build-analysis bot mentioned this pull request Oct 23, 2022
Closed
@radical
Copy link
Member Author

radical commented Oct 24, 2022

Failures are unrelated.

maraf
maraf approved these changes Oct 25, 2022
View reviewed changes
Copy link
Member

@maraf maraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@radical radical merged commit 94c9d02 into dotnet:main Oct 25, 2022
@radical radical deleted the chrome-provisioning branch October 25, 2022 08:18
@ghost ghost locked as resolved and limited conversation to collaborators Nov 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maraf maraf maraf approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@kg kg Awaiting requested review from kg

@thaystg thaystg Awaiting requested review from thaystg

@radekdoulik radekdoulik Awaiting requested review from radekdoulik

@pavelsavara pavelsavara Awaiting requested review from pavelsavara pavelsavara is a code owner

Assignees

@radical radical

Labels
arch-wasm WebAssembly architecture area-Infrastructure-mono
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@radical @maraf @halter73