JIT: fix out of bounds read during SPMI collection #77147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When recording the profile data into the method context, SPMI was assuming all data items were `sizeof(uintptr_t)` which is not guaranteed. Use the proper size. Fixes dotnet#76991.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
ghost
assigned 
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsWhen recording the profile data into the method context, SPMI was assuming all data items were Fixes #76991.
|
|
@jakobbotsch PTAL See #76991 for analysis of the issue. |
BruceForstall
approved these changes
Oct 18, 2022
| case ICorJitInfo::PgoInstrumentationKind::MethodHandle: | ||
| return sizeof(uintptr_t); | ||
| default: | ||
| LogError("Unexpedted pgo schema data size (kind = %d)", kind); |
jakobbotsch
approved these changes
Oct 18, 2022
|
Windows x64 NAOT looks like #76801 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When recording the profile data into the method context, SPMI was assuming all data items were
sizeof(uintptr_t)which is not guaranteed. Use the proper size.Fixes #76991.