Clearing all cards for free regions #77224
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixed two issues associated with card table clearing.
When we return a region to the free region list, we can clear the cards.
If we use
heap_segment_mem (region)
, this will always be 0x20 bytes after the start of the page. Thealign_on_card
logic insideclear_card_for_addresses
will skip resetting the card for the first page.Before these fixes, #76801 is always failing with
*card_word == 1
. This is because the initial card (i.e. the least significant bit) cannot be reset because of the alignment.After these fixes, the test case no longer fails locally after running for 4 hours in a loop.