Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set DNER for all local fields #77341

Merged
merged 1 commit into from
Oct 22, 2022

Conversation

SingleAccretion
Copy link
Contributor

@SingleAccretion SingleAccretion commented Oct 22, 2022

I noticed our stress was deeply red, this should fix one of the offenders at least.

Fixes #77300.

No diffs.

Not just the promoted ones.
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Oct 22, 2022
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Oct 22, 2022
@ghost
Copy link

ghost commented Oct 22, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

I noticed our stress was deeply red, this should fix one of the offenders at least.

Fixes #77300.

Author: SingleAccretion
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@SingleAccretion SingleAccretion marked this pull request as ready for review October 22, 2022 16:54
@SingleAccretion
Copy link
Contributor Author

@dotnet/jit-contrib

@EgorBo
Copy link
Member

EgorBo commented Oct 22, 2022

Nice! Any idea what broke it? 🙂

@SingleAccretion
Copy link
Contributor Author

SingleAccretion commented Oct 22, 2022

Likely exposed by #77102.

@EgorBo EgorBo merged commit 4e85471 into dotnet:main Oct 22, 2022
@SingleAccretion SingleAccretion deleted the Make-Stress-A-Bit-Less-Red branch October 24, 2022 17:08
kunalspathak added a commit to kunalspathak/runtime that referenced this pull request Oct 30, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Nov 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failure readytorun\\coreroot_determinism\\coreroot_determinism\\coreroot_determinism.cmd
2 participants