Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce FIELD_ADDR and use it for TLS statics and instance class fields #77353

Merged
merged 16 commits into from
Nov 10, 2022
Merged

Introduce FIELD_ADDR and use it for TLS statics and instance class fields #77353

merged 16 commits into from
Nov 10, 2022

Commits on Oct 23, 2022

  1. Introduce GT_FIELD_ADDR

    @SingleAccretion
    SingleAccretion committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    95268ce View commit details
    Browse the repository at this point in the history

  2. Add FIELD_ADDR to fgAddrCouldBeNull

    @SingleAccretion
    SingleAccretion committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    f2424bd View commit details
    Browse the repository at this point in the history

  3. Add gtNewFieldAddrNode; move gtNewFieldRef

    @SingleAccretion
    SingleAccretion committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    3275205 View commit details
    Browse the repository at this point in the history

  4. Implement Windows x86 TLS via FIELD_ADDR 

    Tested manually to work as well as it did before.
    @SingleAccretion
    SingleAccretion committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    042342a View commit details
    Browse the repository at this point in the history

  5. Silence the IR checker

    @SingleAccretion
    SingleAccretion committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    ab0774b View commit details
    Browse the repository at this point in the history

  6. Minor code cleanup

    @SingleAccretion
    SingleAccretion committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    0693d11 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2022

  1. Prepare morph for instance FIELD_ADDRs

    @SingleAccretion
    SingleAccretion committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    3d9b5bc View commit details
    Browse the repository at this point in the history

  2. Fix ObjectAllocator

    @SingleAccretion
    SingleAccretion committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    16fb23c View commit details
    Browse the repository at this point in the history

  3. Use FIELD_ADDR in ld[s]flda import

    @SingleAccretion
    SingleAccretion committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    b621b7b View commit details
    Browse the repository at this point in the history

  4. Work around morphing issues 

    With NativeAOT, we can have FIELD_ADDR nodes that are
effectively NOPs (those for the method table pointer field).

This means not all operators that the expansion produces
will be simple (in fact, they can be more or less arbitrary).

This means we cannot simply call "fgMorphSmpOp" as we used to.
Unfortunately, we cannot just call "fgMorphTree" either, because
it propagates assertions on newly created (or, I suppose, bashed)
IND nodes. This creates lots of new cases where GTF_ORDER_SIDEEFF
is applied to these nodes, affecting CQ.

Work around this by calling "fgMorphTree" for non-simple operators
only.
    @SingleAccretion
    SingleAccretion committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    52ef7a6 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2022

  1. Merge branch 'main' into Field-Addr-Upstream

    @SingleAccretion
    SingleAccretion committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    eb427c5 View commit details
    Browse the repository at this point in the history

  2. Actually fix merge conflicts

    @SingleAccretion
    SingleAccretion committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    f5396d3 View commit details
    Browse the repository at this point in the history

  3. Clang format knows better

    @SingleAccretion
    SingleAccretion committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    778cf2b View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2022

  1. Merge branch 'main' into Field-Addr-Upstream

    @SingleAccretion
    SingleAccretion committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    24d7439 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2022

  1. Merge branch 'main' into Field-Addr-Upstream

    @SingleAccretion
    SingleAccretion committed Nov 6, 2022
    Configuration menu
    Copy the full SHA
    b752ecf View commit details
    Browse the repository at this point in the history

  2. Fix merge error

    @SingleAccretion
    SingleAccretion committed Nov 6, 2022
    Configuration menu
    Copy the full SHA
    37d611c View commit details
    Browse the repository at this point in the history