Ensure JsonConverter<T>.Read/WriteAsPropertyName methods are user-callable.#77488
Merged
eiriktsarpalis merged 1 commit intodotnet:mainfrom Oct 28, 2022
Merged
Conversation
…lable. Also adds property name serialization for TimeSpan, TimeOnly, DateOnly, Uri and Version built-in converters. Fix dotnet#77326
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis Issue DetailsAlso adds property name serialization for TimeSpan, TimeOnly, DateOnly, Uri and Version built-in converters. Fix #77326
|
krwq
reviewed
Oct 26, 2022
...tem.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/Serialization/CollectionTests.cs
Show resolved
Hide resolved
krwq
reviewed
Oct 26, 2022
| { | ||
| await Assert.ThrowsAsync<NotSupportedException>(async () => await Serializer.DeserializeWrapper<IReadOnlyDictionary<Uri, int>>(@"{""http://foo"":1}")); | ||
| await Assert.ThrowsAsync<NotSupportedException>(async () => await Serializer.SerializeWrapper(new GenericIReadOnlyDictionaryWrapper<Uri, int>(new Dictionary<Uri, int> { { new Uri("http://foo"), 1 } }))); | ||
| await Assert.ThrowsAsync<NotSupportedException>(async () => await Serializer.DeserializeWrapper<IReadOnlyDictionary<JsonNode, int>>(@"{""key"":1}")); |
Member
Author
There was a problem hiding this comment.
They now support property name serialization.
krwq
reviewed
Oct 26, 2022
|
|
||
| internal override Uri ReadAsPropertyNameCore(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options) | ||
| { | ||
| Debug.Assert(reader.TokenType is JsonTokenType.PropertyName); |
Member
Author
There was a problem hiding this comment.
Yes, Uri key serialization was not supported.
layomia
reviewed
Oct 27, 2022
...ies/System.Text.Json/src/System/Text/Json/Serialization/Converters/Value/VersionConverter.cs
Show resolved
Hide resolved
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonConverterOfT.cs
Show resolved
Hide resolved
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonConverterOfT.cs
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also adds property name serialization for TimeSpan, TimeOnly, DateOnly, Uri and Version built-in converters.
Fix #77326