[release/7.0] [wasm][debugger] Fixing when trying to call mono functions in a non wasm page #77501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @thaystg Issue DetailsBackport of #77496 to release/7.0 /cc @thaystg Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
|
@thaysg When this is ready, please add the |
rbhanda
added
Servicing-approved
|
@thaystg can you please get a code review sign-off? |
thaystg
approved these changes
Nov 3, 2022
lewing
approved these changes
Nov 3, 2022
|
CI failures are:
|
|
Approved by Tactics, signed off by code reviewer. CI failures unrelated. No OOB package authoring changes needed for this PR. Ready to merge. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #77496 to release/7.0
/cc @thaystg
Customer Impact
The customer is trying to login in its blazor wasm app. During some redirections to other pages caused by the login process, the BrowserDebugProxy receives a new debug context from the browser and try to check if it’s a wasm app evaluating some commands, the first one works well the second one throws an exception. This is not something easy to reproduce, but sometimes while login this may happen, then the debugger crashes and the debug session is terminated.
Testing
Manually tested.
Risk
Low risk, only adding a try catch to ignore any error that we can get on RuntimeReady method, because it's not a wasm page.
IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.