-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/6.0] Fix KeepNativeSymbols to work on mono as well (backport of #66594) #77506
[release/6.0] Fix KeepNativeSymbols to work on mono as well (backport of #66594) #77506
Conversation
fab82ba
to
bc3084a
Compare
@marek-safar @directhex this needs to go through Tactics. When/if this is ready, please add the |
@omajid @ayakael @directhex I see some CI failures that I haven't seen in any other backport PR. Are they related to this change? @directhex can you please provide a code review sign-off? |
bc3084a
to
3cec0ed
Compare
It really shouldn't be, as |
3cec0ed
to
3b8eadb
Compare
Ping @directhex @marek-safar for a code review-sign off. |
CI failure confirmed offline to be unrelated. Signed off by area owners. Approved by Tactics. No OOB package authoring changes needed. Ready to merge. |
Backport of #66594
Per @omajid:
Customer impact
Source-build with mono-flavored runtime is problematic without this patch.
Testing
Risk
Low, as it is already in
main
, and only activates whenKeepNativeSymbols!=true