Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allocate boxed static structs on Frozen Object Heap #77737

Merged
merged 41 commits into from
Nov 13, 2022
Merged

Allocate boxed static structs on Frozen Object Heap #77737

merged 41 commits into from
Nov 13, 2022

Commits on Nov 1, 2022

  1. Smarter approach suggested by SingleAccretion

    @EgorBo
    EgorBo committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    77a42b7 View commit details
    Browse the repository at this point in the history

  2. Address Jan's feedback, Jakob noticed invalid contract in AllocateSta… 

    …ticBoxes
    @EgorBo
    EgorBo committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    2b2b2ec View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2022

  1. Update src/coreclr/vm/methodtable.cpp 

    Co-authored-by: Jan Kotas <jkotas@microsoft.com>
    @EgorBo @jkotas
    EgorBo and jkotas authored Nov 2, 2022
    Configuration menu
    Copy the full SHA
    b524f0d View commit details
    Browse the repository at this point in the history

  2. Address feedback

    @EgorBo
    EgorBo committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    a96a664 View commit details
    Browse the repository at this point in the history

  3. Clean up

    @EgorBo
    EgorBo committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    7ebf214 View commit details
    Browse the repository at this point in the history

  4. give up if GetBase() returns nullptr

    @EgorBo
    EgorBo committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    ec21c92 View commit details
    Browse the repository at this point in the history

  5. does this help

    @EgorBo
    EgorBo committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    63e6387 View commit details
    Browse the repository at this point in the history

  6. disable for foh forced 8byte alignment 32bit targets

    @EgorBo
    EgorBo committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    ca4a77e View commit details
    Browse the repository at this point in the history

  7. Update methodtable.cpp

    @EgorBo
    EgorBo authored Nov 2, 2022
    Configuration menu
    Copy the full SHA
    16a2438 View commit details
    Browse the repository at this point in the history

  8. Update src/coreclr/vm/jitinterface.cpp 

    Co-authored-by: Jan Kotas <jkotas@microsoft.com>
    @EgorBo @jkotas
    EgorBo and jkotas authored Nov 2, 2022
    Configuration menu
    Copy the full SHA
    d38e42b View commit details
    Browse the repository at this point in the history

  9. Update src/coreclr/vm/jitinterface.cpp 

    Co-authored-by: Jan Kotas <jkotas@microsoft.com>
    @EgorBo @jkotas
    EgorBo and jkotas authored Nov 2, 2022
    Configuration menu
    Copy the full SHA
    9868525 View commit details
    Browse the repository at this point in the history

  10. Update jitinterface.cpp

    @EgorBo
    EgorBo authored Nov 2, 2022
    Configuration menu
    Copy the full SHA
    4b7ca2b View commit details
    Browse the repository at this point in the history

  11. try fix

    @EgorBo
    EgorBo committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    8c45daa View commit details
    Browse the repository at this point in the history

  12. Update jitinterface.cpp

    @EgorBo
    EgorBo authored Nov 2, 2022
    Configuration menu
    Copy the full SHA
    68a130b View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2022

  1. Merge branch 'main' of github.com:dotnet/runtime into boxed-statics-foh

    @EgorBo
    EgorBo committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    20127aa View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2022

  1. Revert to getFieldInfo

    @EgorBo
    EgorBo committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    94ae8f1 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2022

  1. Use fieldLookup

    @EgorBo
    EgorBo committed Nov 5, 2022
    Configuration menu
    Copy the full SHA
    1739a55 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2022

  1. Run tests on CI (WIP), works locally

    @EgorBo
    EgorBo committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    78448f1 View commit details
    Browse the repository at this point in the history

  2. Delete getFieldAddress

    @EgorBo
    EgorBo committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    faa5e51 View commit details
    Browse the repository at this point in the history

  3. Fix regression around invariant ref-type statics

    @EgorBo
    EgorBo committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    90b3e1b View commit details
    Browse the repository at this point in the history

  4. Remove getFieldAddress

    @EgorBo
    EgorBo committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    6dc5a18 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' of github.com:dotnet/runtime into boxed-statics-foh

    @EgorBo
    EgorBo committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    8d9f172 View commit details
    Browse the repository at this point in the history

  6. Address feedback

    @EgorBo
    EgorBo committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    bff3b1f View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2022

  1. Merge branch 'main' of github.com:dotnet/runtime into boxed-statics-foh

    @EgorBo
    EgorBo committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    a35f7d1 View commit details
    Browse the repository at this point in the history

  2. Implement JIT/EE level cache for fields' addresses

    @EgorBo
    EgorBo committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    cfdb18a View commit details
    Browse the repository at this point in the history

  3. Implement JIT/EE level cache for fields' addresses

    @EgorBo
    EgorBo committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    f6f827d View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' of github.com:dotnet/runtime into boxed-statics-foh

    @EgorBo
    EgorBo committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    5b3d4fe View commit details
    Browse the repository at this point in the history

  5. Fix CQ regression around EqualityComparer.Default

    @EgorBo
    EgorBo committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    3b5c44f View commit details
    Browse the repository at this point in the history

  6. Address Jan's feedback

    @EgorBo
    EgorBo committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    c5d6b55 View commit details
    Browse the repository at this point in the history

  7. Update methodtable.cpp

    @EgorBo
    EgorBo authored Nov 9, 2022
    Configuration menu
    Copy the full SHA
    e25cfa3 View commit details
    Browse the repository at this point in the history

  8. Apply suggestions from code review 

    Co-authored-by: Jan Kotas <jkotas@microsoft.com>
    @EgorBo @jkotas
    EgorBo and jkotas authored Nov 9, 2022
    Configuration menu
    Copy the full SHA
    890ab36 View commit details
    Browse the repository at this point in the history

  9. Address feedback

    @EgorBo
    EgorBo committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    c100079 View commit details
    Browse the repository at this point in the history

  10. Address SingleAccretion's feedback

    @EgorBo
    EgorBo committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    89a99f0 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2022

  1. Fix FixedAddressValueType test - it didn't expect frozen statics

    @EgorBo
    EgorBo committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    29ff0de View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:dotnet/runtime into boxed-statics-foh

    @EgorBo
    EgorBo committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    ff5b6e7 View commit details
    Browse the repository at this point in the history

  3. Update FixedAddressValueType.cs

    @EgorBo
    EgorBo authored Nov 10, 2022
    Configuration menu
    Copy the full SHA
    71ff574 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2022

  1. Merge branch 'boxed-statics-foh' of github.com:EgorBo/runtime-1 into … 

    …boxed-statics-foh
    @EgorBo
    EgorBo committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    d8a7d46 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2022

  1. Merge branch 'main' of github.com:dotnet/runtime into boxed-statics-foh

    @EgorBo
    EgorBo committed Nov 12, 2022
    Configuration menu
    Copy the full SHA
    c6bdcd7 View commit details
    Browse the repository at this point in the history

  2. Resolve conflicts

    @EgorBo
    EgorBo committed Nov 12, 2022
    Configuration menu
    Copy the full SHA
    c92a6c3 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2022

  1. Merge branch 'main' of github.com:dotnet/runtime into boxed-statics-foh

    @EgorBo
    EgorBo committed Nov 13, 2022
    Configuration menu
    Copy the full SHA
    43c5724 View commit details
    Browse the repository at this point in the history

  2. Fix "is removable field" check

    @EgorBo
    EgorBo committed Nov 13, 2022
    Configuration menu
    Copy the full SHA
    3db4522 View commit details
    Browse the repository at this point in the history