[wasm] Enable System.Numerics vectors SIMD #78068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 9, 2022
…m-numerics-vectors-simd
ghost
closed this
|
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
radekdoulik
requested review from
vargaz,
lambdageek,
SamMonoRT and
marek-safar
as code owners
vargaz
approved these changes
Dec 12, 2022
|
runtime (Build Browser wasm Linux Release LibraryTests_AOT) fails on main too, for example in this CI run https://github.com/dotnet/runtime/runs/9978728829 |
radekdoulik
added a commit
to radekdoulik/runtime
that referenced
this pull request
Dec 14, 2022
This should fix size regression introduce with dotnet#78068 The untrimmed S.N.Vector class added few kilobytes to the assemblies of the bench sample. That wasn't that bad, OTOH the code produced by the aot compiler was much larger, 5MB in this case. So this will case default non-SIMD case. In the case of SIMD build we will need more investigation.
radical
pushed a commit
that referenced
this pull request
Dec 14, 2022
This should fix size regression introduce with #78068 The untrimmed S.N.Vector class added few kilobytes to the assemblies of the bench sample. That wasn't that bad, OTOH the code produced by the aot compiler was much larger, 5MB in this case. So this will case default non-SIMD case. In the case of SIMD build we will need more investigation.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps in cases where there's only S.N.Vector path in the BCL code, like
SpanHelpers.IndexOfChar(ref char searchSpace, char value, int length). In this case theSpan:IndexOf charmeasurement improves from 0.0143ms to 0.0114ms.