Don't emit manifest for NativeRuntimeEventSource #78213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommcdon
approved these changes
Nov 11, 2022
brianrob
approved these changes
Nov 12, 2022
davmason
added a commit
to davmason/runtime
that referenced
this pull request
Nov 20, 2022
davmason
added a commit
to davmason/runtime
that referenced
this pull request
Nov 20, 2022
This was referenced Nov 30, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #77014
The managed NativeRuntimeEventSource is conceptually an extension of the native coreclr provider, we should not emit the manifest for it since they are very large and there could be many dotnet processes running.