Mono: Replace exception strings with those stored in the resx file (#34056)

src/mono/System.Private.CoreLib/src/Mono/HotReload.cs

@@ -100,14 +100,14 @@ private FieldStore (object? loc)
 
     public static FieldStore Create (RuntimeTypeHandle type)
     {
-        Type t = Type.GetTypeFromHandle(type) ?? throw new ArgumentException(nameof(type), "Type handle was null");
+        Type t = Type.GetTypeFromHandle(type) ?? throw new ArgumentException(SR.Format(SR.Arg_NullTypeHandleReferenceException, nameof(type)));
         object? loc;
         if (t.IsPrimitive || t.IsValueType)
             loc = RuntimeHelpers.GetUninitializedObject(t);
         else if (t.IsClass || t.IsInterface)
             loc = null;
         else
-            throw new ArgumentException("EnC: Expected a primitive, valuetype, class or interface field");
+            throw new ArgumentException(SR.Arg_EnC);
         /* FIXME: do we want FieldStore to be pinned? */
         return new FieldStore(loc);
     }

src/mono/System.Private.CoreLib/src/System/ArgIterator.cs

@@ -47,7 +47,7 @@ public void End()
 
         public override bool Equals(object? o)
         {
-            throw new NotSupportedException("ArgIterator does not support Equals.");
+            throw new NotSupportedException(SR.PlatformNotSupported_ArgIterator);
         }
 
         public override int GetHashCode()
@@ -59,7 +59,7 @@ public override int GetHashCode()
         public TypedReference GetNextArg()
         {
             if (num_args == next_arg)
-                throw new InvalidOperationException("Invalid iterator position.");
+                throw new InvalidOperationException(SR.InvalidOperation_InvalidIteratorPosition);
             TypedReference result = default;
             unsafe
             {
@@ -75,7 +75,7 @@ public TypedReference GetNextArg()
         public TypedReference GetNextArg(RuntimeTypeHandle rth)
         {
             if (num_args == next_arg)
-                throw new InvalidOperationException("Invalid iterator position.");
+                throw new InvalidOperationException(SR.InvalidOperation_InvalidIteratorPosition);
             TypedReference result = default;
             unsafe
             {
@@ -90,7 +90,7 @@ public TypedReference GetNextArg(RuntimeTypeHandle rth)
         public RuntimeTypeHandle GetNextArgType()
         {
             if (num_args == next_arg)
-                throw new InvalidOperationException("Invalid iterator position.");
+                throw new InvalidOperationException(SR.InvalidOperation_InvalidIteratorPosition);
             return new RuntimeTypeHandle(IntGetNextArgType());
         }
 

src/mono/System.Private.CoreLib/src/System/Delegate.Mono.cs

@@ -427,7 +427,7 @@ private static bool IsArgumentTypeMatchWithThis(Type delArgType, Type argType, b
 
         protected virtual object? DynamicInvokeImpl(object?[]? args)
         {
-            MethodInfo _method = Method ?? throw new NullReferenceException ("method_info is null");
+            MethodInfo _method = Method ?? throw new NullReferenceException (SR.NullReference_This);
 
             object? target = _target;
 

src/mono/System.Private.CoreLib/src/System/ModuleHandle.cs

@@ -71,7 +71,7 @@ public RuntimeTypeHandle ResolveTypeHandle(int typeToken, RuntimeTypeHandle[]? t
                 throw new ArgumentNullException(string.Empty, "Invalid handle");
             IntPtr res = RuntimeModule.ResolveTypeToken(value, typeToken, ptrs_from_handles(typeInstantiationContext), ptrs_from_handles(methodInstantiationContext), out _);
             if (res == IntPtr.Zero)
-                throw new TypeLoadException(string.Format("Could not load type '0x{0:x}' from assembly '0x{1:x}'", typeToken, value.ToInt64()));
+                throw new TypeLoadException(SR.Format("Could not load type '0x{0:x}' from assembly '0x{1:x}'", typeToken, value.ToInt64()));
             else
                 return new RuntimeTypeHandle(res);
         }
@@ -83,7 +83,7 @@ public RuntimeMethodHandle ResolveMethodHandle(int methodToken, RuntimeTypeHandl
                 throw new ArgumentNullException(string.Empty, "Invalid handle");
             IntPtr res = RuntimeModule.ResolveMethodToken(value, methodToken, ptrs_from_handles(typeInstantiationContext), ptrs_from_handles(methodInstantiationContext), out _);
             if (res == IntPtr.Zero)
-                throw new Exception(string.Format("Could not load method '0x{0:x}' from assembly '0x{1:x}'", methodToken, value.ToInt64()));
+                throw new Exception(SR.Format("Could not load method '0x{0:x}' from assembly '0x{1:x}'", methodToken, value.ToInt64()));
             else
                 return new RuntimeMethodHandle(res);
         }
@@ -96,7 +96,7 @@ public RuntimeFieldHandle ResolveFieldHandle(int fieldToken, RuntimeTypeHandle[]
 
             IntPtr res = RuntimeModule.ResolveFieldToken(value, fieldToken, ptrs_from_handles(typeInstantiationContext), ptrs_from_handles(methodInstantiationContext), out _);
             if (res == IntPtr.Zero)
-                throw new Exception(string.Format("Could not load field '0x{0:x}' from assembly '0x{1:x}'", fieldToken, value.ToInt64()));
+                throw new Exception(SR.Format("Could not load field '0x{0:x}' from assembly '0x{1:x}'", fieldToken, value.ToInt64()));
             else
                 return new RuntimeFieldHandle(res);
         }

src/mono/System.Private.CoreLib/src/System/Reflection/CustomAttribute.cs

@@ -158,7 +158,7 @@ internal static object[] GetCustomAttributes(ICustomAttributeProvider obj, Type
             if (!inherit && res.Length == 1)
             {
                 if (res[0] == null)
-                    throw new CustomAttributeFormatException("Invalid custom attribute format");
+                    throw new CustomAttributeFormatException(SR.CustomAttributeFormat_InvalidCustomAttributeFormat);
 
                 if (attributeType != null)
                 {
@@ -206,7 +206,7 @@ internal static object[] GetCustomAttributes(ICustomAttributeProvider obj, Type
                     foreach (object attr in res)
                     {
                         if (attr == null)
-                            throw new CustomAttributeFormatException("Invalid custom attribute format");
+                            throw new CustomAttributeFormatException(SR.CustomAttributeFormat_InvalidCustomAttributeFormat);
                     }
                     var result = new Attribute[res.Length];
                     res.CopyTo(result, 0);
@@ -217,7 +217,7 @@ internal static object[] GetCustomAttributes(ICustomAttributeProvider obj, Type
                 foreach (object attr in res)
                 {
                     if (attr == null)
-                        throw new CustomAttributeFormatException("Invalid custom attribute format");
+                        throw new CustomAttributeFormatException(SR.CustomAttributeFormat_InvalidCustomAttributeFormat);
 
                     Type attrType = attr.GetType();
                     if (attributeType != null && !attributeType.IsAssignableFrom(attrType))
@@ -244,7 +244,7 @@ internal static object[] GetCustomAttributes(ICustomAttributeProvider obj, Type
                 {
                     AttributeUsageAttribute usage;
                     if (attr == null)
-                        throw new CustomAttributeFormatException("Invalid custom attribute format");
+                        throw new CustomAttributeFormatException(SR.CustomAttributeFormat_InvalidCustomAttributeFormat);
 
                     Type attrType = attr.GetType();
                     if (attributeType != null)
@@ -376,7 +376,7 @@ internal static IList<CustomAttributeData> GetCustomAttributesData(ICustomAttrib
                     foreach (CustomAttributeData attrData in res)
                     {
                         if (attrData == null)
-                            throw new CustomAttributeFormatException(Message);
+                            throw new CustomAttributeFormatException(SR.CustomAttributeFormat_InvalidCustomAttributeFormat);
                     }
 
                     var result = new CustomAttributeData[res.Count];
@@ -389,7 +389,7 @@ internal static IList<CustomAttributeData> GetCustomAttributesData(ICustomAttrib
                     foreach (CustomAttributeData attrData in res)
                     {
                         if (attrData == null)
-                            throw new CustomAttributeFormatException(Message);
+                            throw new CustomAttributeFormatException(SR.CustomAttributeFormat_InvalidCustomAttributeFormat);
                         if (!attributeType.IsAssignableFrom(attrData.AttributeType))
                             continue;
                         a.Add(attrData);
@@ -410,7 +410,7 @@ internal static IList<CustomAttributeData> GetCustomAttributesData(ICustomAttrib
                 {
                     AttributeUsageAttribute usage;
                     if (attrData == null)
-                        throw new CustomAttributeFormatException(Message);
+                        throw new CustomAttributeFormatException(SR.CustomAttributeFormat_InvalidCustomAttributeFormat);
 
                     Type attrType = attrData.AttributeType;
                     if (attributeType != null)

src/mono/System.Private.CoreLib/src/System/Reflection/Emit/AssemblyBuilder.Mono.cs

@@ -208,7 +208,7 @@ private AssemblyBuilder(AssemblyName n, AssemblyBuilderAccess access)
             aname = (AssemblyName)n.Clone();
 
             if (!Enum.IsDefined(typeof(AssemblyBuilderAccess), access))
-                throw new ArgumentException(string.Format(CultureInfo.InvariantCulture,
+                throw new ArgumentException(SR.Format(CultureInfo.InvariantCulture,
                     "Argument value {0} is not valid.", (int)access),
                     nameof(access));
 
@@ -336,7 +336,7 @@ internal static Type MakeGenericType(Type gtd, Type[] typeArguments) =>
             if (res is TypeBuilder)
             {
                 if (throwOnError)
-                    throw new TypeLoadException(string.Format("Could not load type '{0}' from assembly '{1}'", name, this.name));
+                    throw new TypeLoadException(SR.Format("Could not load type '{0}' from assembly '{1}'", name, this.name));
                 return null;
             }
             return res;

src/mono/System.Private.CoreLib/src/System/Reflection/Emit/ConstructorBuilder.Mono.cs

@@ -70,7 +70,7 @@ internal ConstructorBuilder(TypeBuilder tb, MethodAttributes attributes, Calling
             {
                 for (int i = 0; i < parameterTypes.Length; ++i)
                     if (parameterTypes[i] == null)
-                        throw new ArgumentException("Elements of the parameterTypes array cannot be null", nameof(parameterTypes));
+                        throw new ArgumentException(SR.Argument_NullParameterTypes, nameof(parameterTypes));
 
                 this.parameters = new Type[parameterTypes.Length];
                 Array.Copy(parameterTypes, this.parameters, parameterTypes.Length);
@@ -319,7 +319,7 @@ internal void fixup()
             if (((attrs & (MethodAttributes.Abstract | MethodAttributes.PinvokeImpl)) == 0) && ((iattrs & (MethodImplAttributes.Runtime | MethodImplAttributes.InternalCall)) == 0))
             {
                 if ((ilgen == null) || (ilgen.ILOffset == 0))
-                    throw new InvalidOperationException("Method '" + Name + "' does not have a method body.");
+                    throw new InvalidOperationException(SR.Format(SR.InvalidOperation_MethodDoesNotHaveBody, Name));
             }
             if (IsStatic &&
                 ((call_conv & CallingConventions.VarArgs) != 0 ||
@@ -351,22 +351,22 @@ internal override int get_next_table_index(int table, int count)
         private void RejectIfCreated()
         {
             if (type.is_created)
-                throw new InvalidOperationException("Type definition of the method is complete.");
+                throw new InvalidOperationException(SR.InvalidOperation_MethodBaked);
         }
 
         private static Exception not_supported()
         {
-            return new NotSupportedException("The invoked member is not supported in a dynamic module.");
+            return new NotSupportedException(SR.NotSupported_DynamicModule);
         }
 
         private static Exception not_after_created()
         {
-            return new InvalidOperationException("Unable to change after type has been created.");
+            return new InvalidOperationException(SR.InvalidOperation_TypeHasBeenCreated);
         }
 
         private static Exception not_created()
         {
-            return new NotSupportedException("The type is not yet created.");
+            return new NotSupportedException(SR.InvalidOperation_TypeNotCreated);
         }
     }
 }