-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/6.0] Revert banana RID source build changes from arcade #78362
[release/6.0] Revert banana RID source build changes from arcade #78362
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsI had originally restored these lines in the arcade dependencies update PR with this commit, but a subsequent automated update reverted my commit. Since the CI had already finished with all the concerns resolved, I didn't want to restart the CI, and instead I'm sending this in a separate change. This was also addressed directly in the arcade repo: dotnet/arcade#11604 but this PR is to unblock us for now.
|
Memory serves, this was removed from #77508 and pushed off to arcade after CIs were green. So I reckon that the currently failing test units are infrastructure issues. |
Could this be merged to unblock dotnet/installer#14816? |
@carlossanlop The next arcade update (should be about 45 mins away) has this fix. I can trigger it just for runtime. |
That would be awesome, yes. |
Closing in favor of the upcoming arcade update PR. |
I had originally restored these lines in the arcade dependencies update PR with this commit, but a subsequent automated update reverted my commit. Since the CI had already finished with all the concerns resolved, I didn't want to restart the CI, and instead I'm sending this in a separate change.
This was also addressed directly in the arcade repo: dotnet/arcade#11604 but this PR is to unblock us for now. /cc @ayakael