[release/7.0] Fix ALC lookup from the DAC #78420
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
It seems the SOS commands for ALC lookup have been broken for a bit. Some parts of the impl weren't DAC-ized and caused failures.
|
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov Issue DetailsBackport of #78400 to release/7.0 Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
AaronRobinsonMSFT
added
the
Servicing-consider
|
/cc @tommcdon |
|
@AaronRobinsonMSFT when this is ready, please get an approval from @jeffschwMSFT. If approved by Jeff, then please send an email to Tactics to request merge approval.
Edit: I just asked, we don't have runway. This will have to go into the January release. |
|
@AaronRobinsonMSFT have you sent the Tactics email requesting approval? I can't find it in my inbox. I ask because for the January release, we will only have a one day window to merge servicing PRs, so I want to make sure all the PRs are 100% ready on that day for me to just click the merge button. That window is from Nov. 29th to Nov. 30th. The only thing left for this PR is to get Tactics approval. |
|
@carlossanlop Sent. |
jeffschwMSFT
removed
the
Servicing-consider
|
Approved by Tactics for 7.0.3. |
ghost
locked as resolved and limited conversation to collaborators
Fixes dotnet/diagnostics#3565
Backport of #78400 to release/7.0
/cc @AaronRobinsonMSFT
Customer Impact
The
dumpalccommand in sos was broken in .NET 7 due to some refactoring. This impacts customers and runtime developers that are investigating crashing issues. Note that on non-Windows, thedumpalccommand will crash the debugger without this fix. On Windows an error message is reported indicating a failure to acquire the ALC.This was not reported by a customer. However, it was found by me when investigating a customer reported issue. The fact that it crashes the debugger is enough justification for me since investigating DMPs is a big concern because there is no easy way, other than
dumpalc, to determine the ALC an object resides in.An additional consideration here is the new feature being added to sos, dotnet/diagnostics#3508, will now cause a crash on non-Windows .NET 7 for the very common
dumpmtcommand.Testing
Validated with sos extension locally. The runtime/diagnostics repo has testing that is being added in dotnet/diagnostics#3508.
Risk
Minimal. This permits calling sos commands and has no product impact.