Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] [mono][wasm] Handle delegates decorated with [UnmanagedFunctionPointe… #78426

Merged
merged 4 commits into from
Nov 29, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 15, 2022

Backport of #77709 to release/7.0

/cc @lewing @vargaz

Customer Impact

Customer reported regression from .NET 6 with delegates using [UnmanagedFunctionPointer]

Testing

Manual

Risk

Low, only affects WebAssembly.

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

vargaz and others added 4 commits November 15, 2022 22:26
Co-authored-by: Ankit Jain <radical@gmail.com>
Co-authored-by: Ankit Jain <radical@gmail.com>
Co-authored-by: Ankit Jain <radical@gmail.com>
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@lewing lewing requested a review from maraf November 15, 2022 23:37
@carlossanlop
Copy link
Member

@vargaz @lewing have you sent the Tactics email requesting approval? If not, please add the servicing-consider label and send an email, please.

I ask because for the January release, we will only have a one day window to merge servicing PRs, so I want to make sure all the PRs are 100% ready on that day for me to just click the merge button. That window is from Nov. 29th to Nov. 30th.

The only thing left for this PR to be ready is to get the Tactics approval. The CI failure seems unrelated.

@vargaz
Copy link
Contributor

vargaz commented Nov 21, 2022

Sent

@marek-safar marek-safar added this to the 7.0.x milestone Nov 22, 2022
@marek-safar marek-safar added the Servicing-approved Approved for servicing release label Nov 22, 2022
@SamMonoRT SamMonoRT modified the milestones: 7.0.x, 7.0.2 Nov 29, 2022
@carlossanlop
Copy link
Member

Branding has been done. Milestone is 7.0.2. Signed-off by area owners. Approved by Tactics.
CI failure is unrelated: System.Net.Http.Functional.Tests.SocketsHttpHandler.
Ready to merge. :shipit:

@carlossanlop carlossanlop merged commit ba5c173 into release/7.0 Nov 29, 2022
@carlossanlop carlossanlop deleted the backport/pr-77709-to-release/7.0 branch November 29, 2022 23:11
@ghost ghost locked as resolved and limited conversation to collaborators Dec 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Interop-mono Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants