-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/7.0] [mono][wasm] Handle delegates decorated with [UnmanagedFunctionPointe… #78426
Conversation
…r] in the interp-to-native generator. Fixes #76930.
Co-authored-by: Ankit Jain <radical@gmail.com>
Co-authored-by: Ankit Jain <radical@gmail.com>
Co-authored-by: Ankit Jain <radical@gmail.com>
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
@vargaz @lewing have you sent the Tactics email requesting approval? If not, please add the I ask because for the January release, we will only have a one day window to merge servicing PRs, so I want to make sure all the PRs are 100% ready on that day for me to just click the merge button. That window is from Nov. 29th to Nov. 30th. The only thing left for this PR to be ready is to get the Tactics approval. The CI failure seems unrelated. |
Sent |
Branding has been done. Milestone is 7.0.2. Signed-off by area owners. Approved by Tactics. |
Backport of #77709 to release/7.0
/cc @lewing @vargaz
Customer Impact
Customer reported regression from .NET 6 with delegates using [UnmanagedFunctionPointer]
Testing
Manual
Risk
Low, only affects WebAssembly.
IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.