Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete temporary instrumentation for #76280 #78537

Merged
merged 1 commit into from
Nov 18, 2022
Merged

Delete temporary instrumentation for #76280 #78537

merged 1 commit into from
Nov 18, 2022

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Nov 18, 2022

Fixes #76280

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Nov 18, 2022
@ghost ghost assigned jkotas Nov 18, 2022
@ghost
Copy link

ghost commented Nov 18, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #76280

Author: jkotas
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@jkotas
Copy link
Member Author

jkotas commented Nov 18, 2022

The issue does not repro anymore.

tannergooding
tannergooding approved these changes Nov 18, 2022
View reviewed changes
Copy link
Member

@tannergooding tannergooding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I'd guess this was fixed by the change in backing CPU and so this is likely the issue @EgorBo had found and referenced.

@BruceForstall
Copy link
Member

@tannergooding @jkotas Note that this test failed in our superpmi collection pipeline this past weekend, with this assert:

#78576

This run happens in the "internal" AzDO instance which hasn't switched to the new machines.

@jkotas
Copy link
Member Author

jkotas commented Nov 18, 2022

This run happens in the "internal" AzDO instance which hasn't switched to the new machines.

Do we plan to switch?

@jkotas jkotas merged commit d413cc4 into dotnet:main Nov 18, 2022
@jkotas jkotas deleted the issue-76280 branch November 18, 2022 23:03
@BruceForstall
Copy link
Member

Do we plan to switch?

There are no current plans, AFAIK. When I talked to the internal Engineering Services team about switching, I focused on PR dotnet/runtime testing. I believe there are very few "internal" pipelines that actually run tests, but superpmi-collect does.

Also, fyi, the new machines are being used for Windows/x64, not Linux/x64.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BruceForstall BruceForstall BruceForstall approved these changes

@tannergooding tannergooding tannergooding approved these changes

Assignees

@jkotas jkotas

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test failure JIT\\HardwareIntrinsics\\General\\Vector256\\Vector256_r\\Vector256_r.cmd
3 participants
@jkotas @BruceForstall @tannergooding