Remove TrimStart in PAX extended attributes #78707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlossanlop
requested review from
stephentoub,
adamsitnik,
ViktorHofer,
smasher164 and
jozkee
stephentoub
approved these changes
Nov 22, 2022
jozkee
approved these changes
Nov 22, 2022
|
Should we mark this as a breaking change? |
My gut says no. We're correcting a behavior considered a bug, not changing the way an API is working. |
carlossanlop
added a commit
to carlossanlop/runtime
that referenced
this pull request
Nov 23, 2022
* Remove TrimStart in PAX extended attributes * Adjust existing tests with two extra inline datas. Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
carlossanlop
added a commit
that referenced
this pull request
Nov 29, 2022
…attributes (#78785) * Remove invalidation of whitespace in TryGetNextExtendedAttribute (#78465) * Remove invalidation of whitespace in TryGetNextExtendedAttribute * Add requested test * Remove TrimStart in PAX extended attributes (#78707) * Remove TrimStart in PAX extended attributes * Adjust existing tests with two extra inline datas. Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com> * Tar: Extra tests to confirm extra long paths are not treated as duplicate entries when the full path is in the extended attributes. (#78744) Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com> Co-authored-by: Stephen Toub <stoub@microsoft.com> Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #78465
We don't want to trim the keys or the values retrieved from the extended attributes section. We want to preserved them untouched.