[release/7.0] [wasm] Use "node:crypto" to polyfill getRandomValues on older node #78766
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
requested review from
lewing and
pavelsavara
as code owners
maraf
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsBackport of #78696 to release/7.0 /cc @maraf Customer ImpactCustomers running node older than v19 are able to generate random bytes needed for example to generate guids. TestingUnit tests pass on node v14, v17, v19 RiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
|
/azp run runtime-wasm-libtests |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@maraf can you please address the questions in the Tactics email you sent to unblock the approval? |
carlossanlop
added
Servicing-approved
|
Approved via email by Tactics for 7.0.3 (February). |
|
Approved by Tactics. |
ghost
locked as resolved and limited conversation to collaborators
Backport of #78696 to release/7.0
/cc @maraf
Customer Impact
Customers running node older than v19 are able to generate random bytes needed for example to generate guids.
Without polyfill it fails with exception.
Testing
Unit tests pass on node v14, v17, v19
Risk
IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.