Add support for serializing properties in interface hierarchies

[eiriktsarpalis]

Fix #41749.

cc @captainsafia

[ghost]

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Fix #41749.

cc @captainsafia

Author:	eiriktsarpalis
Assignees:	-
Labels:	area-System.Text.Json
Milestone:	-

[tarekgh]

/_/src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/ReflectionJsonTypeInfoOfT.cs(64,13): Trim analysis error IL2072: System.Text.Json.Serialization.Metadata.ReflectionJsonTypeInfo<T>.LateAddProperties(): 'type' argument does not satisfy 'DynamicallyAccessedMemberTypes.Interfaces' in call to 'System.Text.Json.Reflection.ReflectionExtensions.GetSortedInterfaceHierarchy(Type)'. The return value of method 'System.Text.Json.Serialization.Metadata.JsonTypeInfo.Type.get' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to. [/__w/1/s/src/libraries/sfx.proj]

[tarekgh]

modulo the analyzer failure, LGTM.

[eiriktsarpalis]

/_/src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/ReflectionJsonTypeInfoOfT.cs(64,13): Trim analysis error IL2072: System.Text.Json.Serialization.Metadata.ReflectionJsonTypeInfo<T>.LateAddProperties(): 'type' argument does not satisfy 'DynamicallyAccessedMemberTypes.Interfaces' in call to 'System.Text.Json.Reflection.ReflectionExtensions.GetSortedInterfaceHierarchy(Type)'. The return value of method 'System.Text.Json.Serialization.Metadata.JsonTypeInfo.Type.get' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to. [/__w/1/s/src/libraries/sfx.proj]

The changes seem to have triggered false positive warnings being emitted by the trimmer. After a lot of experimentation, I was able to isolate the issue to the one for loop that was changed to a foreach loop in ReflectionJsonTypeInfoOfT.cs. I refactored the foreach body into a separate method to avoid hitting the issue.

[eiriktsarpalis]

Wasm test failures are unrelated:

eng/testing/wasm-provisioning.targets(102,5): error : Could not find a chrome snapshot folder under https://storage.googleapis.com/chromium-browser-snapshots/Linux_x64, for branch positions 1202 to 1232, for version 107.0.5304.121.

[angelaki]

Just since I'm curious / fast checking haven't found it: where / how are duplicate property named handled?

[eiriktsarpalis]

Same as how they are handled in regular class hierarchies: we throw an exception:

runtime/src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/JsonTypeInfo.cs

Line 826 in 58f59db

ThrowHelper.ThrowInvalidOperationException_SerializerPropertyNameConflict(Type, jsonPropertyInfo.Name);

[angelaki]

Ah sure, Attributes made it possible before, too! Thank you very much.