[wasm] Catch error from loading "node:crypto" module #78916
Conversation
maraf
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsAccording to "node:crypto" documentation, there can be build of node without this module. We silently ignore the error with loading the module until some API requiring it is called.
|
|
/azp run runtime-wasm-libtests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/backport to release/7.0 |
|
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3593244549 |
|
@maraf backporting to release/7.0 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Catch error from loading node:crypto module.
Using index info to reconstruct a base tree...
M src/mono/wasm/runtime/polyfills.ts
Falling back to patching base and 3-way merge...
Auto-merging src/mono/wasm/runtime/polyfills.ts
CONFLICT (content): Merge conflict in src/mono/wasm/runtime/polyfills.ts
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Catch error from loading node:crypto module.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
|
@maraf an error occurred while backporting to release/7.0, please check the run log for details! Error: git am failed, most likely due to a merge conflict. |
* Catch error from loading node:crypto module. * Throw error with explanation when crypto module is not available. * Fix providing error throwing polyfill.
ghost
locked as resolved and limited conversation to collaborators
|
Backport was resubmitted here: #80249 |
According to "node:crypto" documentation, there can be build of node without this module. We silently ignore the error with loading the module until some API requiring it is called.
This restores the behavior before #78696