[release/7.0] Make sure s_currentGenerationTable is safe for profiler attach #78937
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Tagging subscribers to this area: @tommcdon Issue DetailsBackport of #78841 to release/7.0 /cc @cshung Customer ImpactIf we hit this sequence of events, then the profiled .NET process would crash.
TestingThe diagnostics team will run the profiler-specific tests on this commit. RiskThis change does not impact the profiler launch scenario, and nothing can be worse than a crash in the profiler attach scenario. IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
jeffschwMSFT
added
the
Servicing-consider
rbhanda
added
Servicing-approved
|
Branding has been done. Final chosen milestone is 7.0.2. Signed-off by area owners. Approved by Tactics. No OOB package authoring changes needed. CI is green. |
ghost
locked as resolved and limited conversation to collaborators
Backport of #78841 to release/7.0
/cc @cshung
Customer Impact
Customer reported crash on profiler attach. If we hit this sequence of events, then the profiled .NET process would crash.
ICorProfilerimplementation that is interested in GC events is attached later thatTesting
The diagnostics team will run the profiler-specific tests on this commit.
Risk
This change does not impact the profiler launch scenario, and nothing can be worse than a crash in the profiler attach scenario.
IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.