Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Fix path to ping on Android API 21-27 #79076

Merged
merged 1 commit into from
Dec 7, 2022
Merged

[Android] Fix path to ping on Android API 21-27 #79076

merged 1 commit into from
Dec 7, 2022

Conversation

simonrozsival
Copy link
Member

The path to the ping binary on Android is /system/bin/ping. Newer Androids (API 28+) have a symlink for /bin -> /system/bin, so our CI that runs tests on API 29 didn't catch it.

Ref #78990

/cc @wfurt @steveisok

@ghost ghost assigned simonrozsival Dec 1, 2022
@ghost
Copy link

ghost commented Dec 1, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

The path to the ping binary on Android is /system/bin/ping. Newer Androids (API 28+) have a symlink for /bin -> /system/bin, so our CI that runs tests on API 29 didn't catch it.

Ref #78990

/cc @wfurt @steveisok

Author: simonrozsival
Assignees: -
Labels:

area-System.Net, os-android
Milestone: -

@build-analysis build-analysis bot mentioned this pull request Dec 1, 2022
Closed
@steveisok steveisok requested review from steveisok and wfurt December 1, 2022 15:50
@simonrozsival simonrozsival merged commit 59d56cc into dotnet:main Dec 7, 2022
@simonrozsival simonrozsival deleted the fix-android-ping-path branch December 7, 2022 12:36
@akoeplinger
Copy link
Member

@simonrozsival should we backport this?

@simonrozsival
Copy link
Member Author

I didn't think it's worth backporting but now that I've given it another thought I think we should backport it to both .NET 6 and 7.

@simonrozsival
Copy link
Member Author

/backport to release/7.0

@simonrozsival
Copy link
Member Author

/backport to release/6.0

@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2023

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3830538576

@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2023

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/3830541489

This was referenced Jan 3, 2023
Merged
Merged
@akoeplinger akoeplinger mentioned this pull request Jan 11, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Feb 2, 2023
@karelz karelz added this to the 8.0.0 milestone Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@steveisok steveisok steveisok approved these changes

@wfurt wfurt Awaiting requested review from wfurt

Assignees

@simonrozsival simonrozsival

Labels
area-System.Net os-android
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@simonrozsival @akoeplinger @steveisok @karelz